Add BigQueryReader.to_recap #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
criccomini
force-pushed
the
add-bq-reader
branch
4 times, most recently
from
5cce4ad to
16365c7
Compare
|
Dang. The BQ emulator isn't able to start in GH workflows right now because of goccy/bigquery-emulator#208. |
criccomini
force-pushed
the
add-bq-reader
branch
20 times, most recently
from
801c00c to
4cb7cc0
Compare
Recap can now convert BigQuery table schemas to Recap StructTypes. Some notes: 1. Nested types are supported (RECORD, STRUCT) 2. Repeated/ARRAYs are supported 3. JSON types are treated as STRING 4. STRING and BYTES have a max length of 65KiB by default For (4), I had a really hard time nailing down the exact max string size in BQ. [This](https://cloud.google.com/bigquery/docs/reference/standard-sql/data-types) page says they have a 2 byte header on strings/bytes, which I assume is to store the byte length. Thus I went with 65KiB. I'm also using [bigquery-emulator](https://github.com/goccy/bigquery-emulator) to test. I've only included integration tests. Closes #285
criccomini
force-pushed
the
add-bq-reader
branch
from
4cb7cc0 to
19e3fbf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recap can now convert BigQuery table schemas to Recap StructTypes.
Some notes:
For (4), I had a really hard time nailing down the exact max string size in BQ. This page says they have a 2 byte header on strings/bytes, which I assume is to store the byte length. Thus I went with 65KiB.
I'm also using bigquery-emulator to test. I've only included integration tests.
Closes #285