Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove forced column ordering in KMDNoise #1

Closed
hechth opened this issue Nov 16, 2021 · 0 comments · Fixed by #23
Closed

Remove forced column ordering in KMDNoise #1

hechth opened this issue Nov 16, 2021 · 0 comments · Fixed by #23
Assignees

Comments

@hechth
Copy link
Member

hechth commented Nov 16, 2021

The columns should be expected but not in a set order of things.

KMDNoise <- function(df, upper.y = 0.2, lower.y = 0.05, upper.x = NA, lower.x = NA){
names(df)[1] <- "mass"
names(df)[2] <- "intensity"
upper.x <- ifelse(is.na(upper.x)== TRUE, upper.x <- max(df$mass), upper.x <- upper.x)
lower.x <- ifelse(is.na(lower.x)== TRUE, lower.x <- min(df$mass), lower.x <- lower.x)

@hechth hechth self-assigned this Dec 11, 2023
@hechth hechth linked a pull request Dec 11, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

1 participant