Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for SQLite #15

Merged
merged 5 commits into from
Jun 29, 2024
Merged

Add support for SQLite #15

merged 5 commits into from
Jun 29, 2024

Conversation

dbackeus
Copy link
Contributor

@dbackeus dbackeus commented Jun 17, 2024

Opt in to SQLite by setting DB_ADAPTER=sqlite

@dbackeus dbackeus force-pushed the sqlite-support branch 5 times, most recently from f4304ba to 4d5bfe5 Compare June 17, 2024 19:35
@dbackeus dbackeus force-pushed the sqlite-support branch 3 times, most recently from 8e13e1e to 4f61237 Compare June 18, 2024 11:47
sqlite3 gem version 2.x fixes this but 1.x is required by Rails.

Reference: sparklemotion/sqlite3-ruby#434
@dbackeus dbackeus marked this pull request as draft June 19, 2024 14:54
@@ -1,7 +1,7 @@
# This Dockerfile produces a production ready image of talos-manager.

ARG RUBY_VERSION=3.2.0
FROM ruby:${RUBY_VERSION}-alpine as base
FROM ruby:${RUBY_VERSION}-slim as base
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE: Had to switch from alpine to slim to fix sparklemotion/sqlite3-ruby#434

@dbackeus dbackeus marked this pull request as ready for review June 29, 2024 20:08
@dbackeus dbackeus merged commit ec5152f into master Jun 29, 2024
1 check passed
@dbackeus dbackeus deleted the sqlite-support branch June 29, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant