SubDL subtitles provider

[KingLucius]

• Adds SubDL subtitles provider.
• Imdb Id passing now correctly.

Closes #1080
Closes #1076

[KingLucius]

there is another option that we can getMetaData() inside ShowMirrosDialog() and pass the imdb to openOnlineSubPicker()

[fire-light42]

Nice addition, however I will be a bit harsh with the code quality.

What you have done is hardcoded imdb into too many places using a string instead of a long, why?. This may work for this one thing, but does not allow for easy future expansion as it ties cs3 to imdb.

[KingLucius]

Nice addition, however I will be a bit harsh with the code quality.

What you have done is hardcoded imdb into too many places using a string instead of a long, why?. This may work for this one thing, but does not allow for easy future expansion as it ties cs3 to imdb.

In most cases you need and will use the imdb ID as a full one with ttxxxxx and that's the same format that be added from trakt & TMDB apis
Only Opensubtitles uses only the numbers without tt
So using it as string and only replace in Opensubtitles sub provider is the logic thing to do
To avoid adding the tt in most cases
Even in MainApi it's added as string because originally imdb ID is string not int like tmdb

[fire-light42]

Alright, however normally with stuff like this (like mal and anilist) when it can be stored as an int is is stored as an int

[KingLucius]

Alright, however normally with stuff like this (like mal and anilist) when it can be stored as an int is is stored as an int

Sure, I think only imdb needs to be stored as string, all others would be stored as Int

[KingLucius]

We can later update MainApi to store applicable IDs as int.
Then we can remove the toInt() later

If you agree, I can me Todo before merging