Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the option to hide video controls #1210

Merged
merged 4 commits into from
Jul 25, 2024

Conversation

epireyn
Copy link
Contributor

@epireyn epireyn commented Jul 23, 2024

Closes #1190

@KingLucius
Copy link
Contributor

KingLucius commented Jul 24, 2024

  1. This one is not needed on TV as there is a lot of space under the progress bar, so I think we should hide this on TV, check feat(UI): Reorganize Settings #1137
  2. Why not you use a list of buttons ID and map thru them, to avoid bugs in the future if we added another element with different type

@epireyn
Copy link
Contributor Author

epireyn commented Jul 24, 2024

To answer the second point, it only removes Material Buttons and iterates on linear layouts. Any other element is ignored. It makes it easier to add other buttons without the need of maintaining a comprehensive list.

fun iterate(layout: LinearLayout) {
layout.children.forEach {
if (it is MaterialButton) {
it.textSize = 0f
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This leaves the button non centered and with weird padding. Do at least this.

it.textSize = 0f
it.iconPadding = 0
it.iconGravity = MaterialButton.ICON_GRAVITY_TEXT_START
it.setPadding(0,0,0,0)

@LagradOst LagradOst merged commit 15d2d21 into recloudstream:master Jul 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Video Controls With Their Name
5 participants