fix: disallow deser for strings that are too long #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
recmo
approved these changes
Apr 19, 2023
|
I'll fix CI errors and merge. |
|
Can't push pr. Will fix in main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
paradigmxyz/reth#1784 highlighted that deserialization allows strings that are too long, for example
0x000would be successfully deserialized for a single-byteUint.Solution
Ensure that the input string to deserialize is not longer than 2 times the max number of bytes.
Added tests for max value (
0xffff...) inputs and zero value (0x0000...) inputs.PR Checklist