Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LightGBM 3 #1527

Merged
merged 1 commit into from
Sep 16, 2021
Merged

LightGBM 3 #1527

merged 1 commit into from
Sep 16, 2021

Conversation

miguelgfierro
Copy link
Collaborator

Description

Based on John Ehrlinger's feedback.

Let's see if the tests pass with LGBM 3

Related Issues

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

@miguelgfierro
Copy link
Collaborator Author

fyi @ehrlinger

@anargyri
Copy link
Collaborator

Wow, I am amazed, no numpy / numba 💥 😃

@miguelgfierro
Copy link
Collaborator Author

the repo works with LigthGBM >3, see https://dev.azure.com/best-practices/recommenders/_build/results?buildId=51388&view=logs&j=475df697-7465-54db-fcd2-cb9bdea8ab03&t=fc42710a-e5bf-5b46-2a6c-90b8e6347d71

   --- LIST INSTALLED DEPENDENCIES ---
Package            Version
------------------ -------------------
Bottleneck         1.3.2
category-encoders  1.3.0
certifi            2021.5.30
charset-normalizer 2.0.5
click              8.0.1
cornac             1.13.5
cycler             0.10.0
dataclasses        0.8
filelock           3.0.12
huggingface-hub    0.0.17
idna               3.2
importlib-metadata 4.8.1
Jinja2             2.11.3
joblib             1.0.1
kiwisolver         1.3.1
lightfm            1.16
lightgbm           3.2.1

@miguelgfierro miguelgfierro merged commit c9b6d9b into staging Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants