Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Converting the azureml test folder in a package to avoid path 🐛 #1842

Merged
merged 1 commit into from
Nov 11, 2022
Merged

Converting the azureml test folder in a package to avoid path 🐛 #1842

merged 1 commit into from
Nov 11, 2022

Conversation

miguelgfierro
Copy link
Collaborator

Description

Fixes error in the AzureML tests related to the path

Related Issues

Fix #1841

References

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • This PR is being made to staging branch and not to main branch.

@simonzhaoms
Copy link
Collaborator

@miguelgfierro I saw you deleted those init files in the PR #1808, and you added some of them back in this PR now.

Do the other init files also need to be added back?

@simonzhaoms simonzhaoms mentioned this pull request Nov 11, 2022
Closed
@miguelgfierro
Copy link
Collaborator Author

Do the other init files also need to be added back?

I think they don't need to be taken back, only the ones that I added. But let's see.

@miguelgfierro miguelgfierro merged commit 3673c01 into staging Nov 11, 2022
@miguelgfierro miguelgfierro deleted the bug/azureml_paths branch November 11, 2022 06:07
@miguelgfierro miguelgfierro mentioned this pull request Nov 11, 2022
Merged
4 tasks
@miguelgfierro
Copy link
Collaborator Author

@simonzhaoms you were right, this change was not enough. I created a new PR #1845

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loomlike loomlike loomlike approved these changes

@gramhagen gramhagen Awaiting requested review from gramhagen gramhagen is a code owner

@anargyri anargyri Awaiting requested review from anargyri anargyri is a code owner

@wutaomsft wutaomsft Awaiting requested review from wutaomsft wutaomsft is a code owner

@simonzhaoms simonzhaoms Awaiting requested review from simonzhaoms

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miguelgfierro @simonzhaoms @loomlike