-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for Release Recommenders 1.2.0 #2092
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
miguelgfierro
requested review from
gramhagen,
anargyri,
loomlike,
wutaomsft and
SimonYansenZhao
as code owners
April 29, 2024 20:10
SimonYansenZhao
approved these changes
Apr 30, 2024
SimonYansenZhao
added a commit
that referenced
this pull request
May 1, 2024
…2094) * Update SETUP.md Remove left-over reference to conda script that has been deleted. * remove cast to array in similarity functions Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> * remove scipy limitation Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> * flattening matrix so dataframe can be built correctly Signed-off-by: Scott Graham <5720537+gramhagen@users.noreply.github.com> * Adding toarray() suggested by @gramhagen Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> * Added r-precision Signed-off-by: David Davó <david@ddavo.me> * Added r-precision tests Signed-off-by: David Davó <david@ddavo.me> * trying to substitude geta1 with ravel Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> * Changed metric "result" to "result.toarray()" Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Revert recommenders/models/sar/sar_singlenode.py Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Use cooccurrence.toarray() Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * return result if isinstance(result, np.ndarray) else result.toarray() Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Return numpy array instead of numpy matrix Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Prepare for Release Recommenders 1.2.0 (#2092) * New release Recommenders 1.2.0 💥💥 * updated news Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> --------- Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Co-authored-by: miguelgfierro <miguelgfierro@users.noreply.github.com> * Add reference to scenarios to README.md There is no link to the scenarios page from the front page, so it is hard to find. Added reference. --------- Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Scott Graham <5720537+gramhagen@users.noreply.github.com> Signed-off-by: David Davó <david@ddavo.me> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> Co-authored-by: Andreas Argyriou <anargyri@users.noreply.github.com> Co-authored-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Co-authored-by: Scott Graham <5720537+gramhagen@users.noreply.github.com> Co-authored-by: David Davó <david@ddavo.me> Co-authored-by: Simon Zhao <simonyansenzhao@gmail.com>
github-actions bot
pushed a commit
that referenced
this pull request
May 1, 2024
…2094) * Update SETUP.md Remove left-over reference to conda script that has been deleted. * remove cast to array in similarity functions Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> * remove scipy limitation Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> * flattening matrix so dataframe can be built correctly Signed-off-by: Scott Graham <5720537+gramhagen@users.noreply.github.com> * Adding toarray() suggested by @gramhagen Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> * Added r-precision Signed-off-by: David Davó <david@ddavo.me> * Added r-precision tests Signed-off-by: David Davó <david@ddavo.me> * trying to substitude geta1 with ravel Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> * Changed metric "result" to "result.toarray()" Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Revert recommenders/models/sar/sar_singlenode.py Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Use cooccurrence.toarray() Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * return result if isinstance(result, np.ndarray) else result.toarray() Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Return numpy array instead of numpy matrix Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> * Prepare for Release Recommenders 1.2.0 (#2092) * New release Recommenders 1.2.0 💥💥 * updated news Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> --------- Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Co-authored-by: miguelgfierro <miguelgfierro@users.noreply.github.com> * Add reference to scenarios to README.md There is no link to the scenarios page from the front page, so it is hard to find. Added reference. --------- Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Signed-off-by: Scott Graham <5720537+gramhagen@users.noreply.github.com> Signed-off-by: David Davó <david@ddavo.me> Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com> Co-authored-by: Andreas Argyriou <anargyri@users.noreply.github.com> Co-authored-by: miguelgfierro <miguelgfierro@users.noreply.github.com> Co-authored-by: Scott Graham <5720537+gramhagen@users.noreply.github.com> Co-authored-by: David Davó <david@ddavo.me> Co-authored-by: Simon Zhao <simonyansenzhao@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issues
References
Checklist:
git commit -s -m "your commit message"
.staging branch
AND NOT TOmain branch
.