Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for Release Recommenders 1.2.0 #2092

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Prepare for Release Recommenders 1.2.0 #2092

merged 2 commits into from
Apr 30, 2024

Conversation

miguelgfierro
Copy link
Collaborator

Description

Related Issues

References

Checklist:

  • I have followed the contribution guidelines and code style for this project.
  • I have added tests covering my contributions.
  • I have updated the documentation accordingly.
  • I have signed the commits, e.g. git commit -s -m "your commit message".
  • This PR is being made to staging branch AND NOT TO main branch.

Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
@SimonYansenZhao SimonYansenZhao merged commit c81d56b into staging Apr 30, 2024
38 checks passed
@miguelgfierro miguelgfierro deleted the release/120 branch April 30, 2024 10:42
SimonYansenZhao added a commit that referenced this pull request May 1, 2024
…2094)

* Update SETUP.md

Remove left-over reference to conda script that has been deleted.

* remove cast to array in similarity functions

Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>

* remove scipy limitation

Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>

* flattening matrix so dataframe can be built correctly

Signed-off-by: Scott Graham <5720537+gramhagen@users.noreply.github.com>

* Adding toarray() suggested by @gramhagen

Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>

* Added r-precision

Signed-off-by: David Davó <david@ddavo.me>

* Added r-precision tests

Signed-off-by: David Davó <david@ddavo.me>

* trying to substitude geta1 with ravel

Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>

* Changed metric "result" to "result.toarray()"

Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>

* Revert recommenders/models/sar/sar_singlenode.py

Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>

* Use cooccurrence.toarray()

Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>

* return result if isinstance(result, np.ndarray) else result.toarray()

Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>

* Return numpy array instead of numpy matrix

Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>

* Prepare for Release Recommenders 1.2.0 (#2092)

* New release Recommenders 1.2.0 💥💥

* updated news

Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>

---------

Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
Co-authored-by: miguelgfierro <miguelgfierro@users.noreply.github.com>

* Add reference to scenarios to README.md

There is no link to the scenarios page from the front page, so it is hard to find. Added reference.

---------

Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
Signed-off-by: Scott Graham <5720537+gramhagen@users.noreply.github.com>
Signed-off-by: David Davó <david@ddavo.me>
Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>
Co-authored-by: Andreas Argyriou <anargyri@users.noreply.github.com>
Co-authored-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
Co-authored-by: Scott Graham <5720537+gramhagen@users.noreply.github.com>
Co-authored-by: David Davó <david@ddavo.me>
Co-authored-by: Simon Zhao <simonyansenzhao@gmail.com>
github-actions bot pushed a commit that referenced this pull request May 1, 2024
…2094)

* Update SETUP.md

Remove left-over reference to conda script that has been deleted.

* remove cast to array in similarity functions

Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>

* remove scipy limitation

Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>

* flattening matrix so dataframe can be built correctly

Signed-off-by: Scott Graham <5720537+gramhagen@users.noreply.github.com>

* Adding toarray() suggested by @gramhagen

Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>

* Added r-precision

Signed-off-by: David Davó <david@ddavo.me>

* Added r-precision tests

Signed-off-by: David Davó <david@ddavo.me>

* trying to substitude geta1 with ravel

Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>

* Changed metric "result" to "result.toarray()"

Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>

* Revert recommenders/models/sar/sar_singlenode.py

Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>

* Use cooccurrence.toarray()

Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>

* return result if isinstance(result, np.ndarray) else result.toarray()

Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>

* Return numpy array instead of numpy matrix

Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>

* Prepare for Release Recommenders 1.2.0 (#2092)

* New release Recommenders 1.2.0 💥💥

* updated news

Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>

---------

Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
Co-authored-by: miguelgfierro <miguelgfierro@users.noreply.github.com>

* Add reference to scenarios to README.md

There is no link to the scenarios page from the front page, so it is hard to find. Added reference.

---------

Signed-off-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
Signed-off-by: Scott Graham <5720537+gramhagen@users.noreply.github.com>
Signed-off-by: David Davó <david@ddavo.me>
Signed-off-by: Simon Zhao <simonyansenzhao@gmail.com>
Co-authored-by: Andreas Argyriou <anargyri@users.noreply.github.com>
Co-authored-by: miguelgfierro <miguelgfierro@users.noreply.github.com>
Co-authored-by: Scott Graham <5720537+gramhagen@users.noreply.github.com>
Co-authored-by: David Davó <david@ddavo.me>
Co-authored-by: Simon Zhao <simonyansenzhao@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants