Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test coverage #126

Closed
alansaid opened this issue Jan 19, 2017 · 3 comments
Closed

Test coverage #126

alansaid opened this issue Jan 19, 2017 · 3 comments
Labels

Comments

@alansaid
Copy link
Member

Do we want to raise these numbers?

@afcarvalho1991
Copy link
Contributor

Hello @alansaid ,

Do you refer to the coverage metric? http://citeseerx.ist.psu.edu/viewdoc/download?doi=10.1.1.464.8494&rep=rep1&type=pdf

Seems that this is still a broad concept, there no clear definition for coverage.
Do you have your own implementation? If so, what is the formula being used.

Thanks,
André

@alansaid
Copy link
Member Author

alansaid commented Feb 3, 2017

Hi @afcarvalho1991 ,
The numbers I refer to are not related to recommender systems, they are related to how much of the code in RiVal is covered/checked by unit tests.

Currently we have very few of those (~17%), meaning that there is a lot of functionality that is implemented but not tested.

/A

@abellogin
Copy link
Member

Hi @alansaid,

thanks for this tool, it could be very useful as a guide for newcomers so they can implement tests of the missing pieces and understand the framework at the same time.

Right now, it looks like the most covered module is the evaluation one, that is good. However, it would not be too difficult to add tests in the split and core modules.

So, definitively this is a good idea and we should aim at raising those numbers in every release.

Cheers,
Alex

@alansaid alansaid closed this as completed Feb 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants