Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stegen not converting dates #88

Closed
thibautjombart opened this issue Dec 11, 2018 · 1 comment
Closed

stegen not converting dates #88

thibautjombart opened this issue Dec 11, 2018 · 1 comment
Labels

Comments

@thibautjombart
Copy link
Contributor

thibautjombart commented Dec 11, 2018

Stegen case study: not converting dates to dates does not generate errors, but does not work either - dispatching is not working, try and see why, make sure we issue a meaningful error.

This comes from:

incidence("2001-01-01")

Not working.

@zkamvar
Copy link
Member

zkamvar commented Jan 8, 2019

This was a bit difficult for me to parse when I first read it.

For future contributors: please use the reprex package to make a reproducible example like so:

reprex::reprex({
library("incidence")
res <- incidence("2001-01-01")
str(res)
})

This would copy the formatted code to your clipboard that you can paste directly into github:

library("incidence")
res <- incidence("2001-01-01")
str(res)
#>  Date[1:1], format: "2001-01-01"

Created on 2019-01-08 by the reprex package (v0.2.1)

This method makes it easier for us to figure out what the actual behavior was and if we can fix it.

zkamvar added a commit that referenced this issue Jan 9, 2019
This reverts #90 and further addresses #88 by only allowing a narrow set
of valid inputs for character data.
zkamvar added a commit that referenced this issue Jan 10, 2019
This reverts #90 and further addresses #88 by only allowing a narrow set
of valid inputs for character data.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants