Include affine.h in quat.h; remove needless decls #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* affine.h is needed for glm_translate_make * Remove function declarations - glm_mat4_mulv since mat4.h is already included - glm_mul_rot as affine-mat.h is already include - glm_translate as affine.h is included with this change
|
@legends2k the PR is merged, thanks for your contributions 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Including all of
cglm/cglm.his sometimes an overkill. Just includingcglm/quat.hresults in a compiler error foraffine.hinquat.hfor definition ofglm_translate_makeglm_mat4_mulvsincemat4.his already includedglm_mul_rotasaffine-mat.his already includedglm_translateasaffine.his included with this change