Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spelling and grammar on troubleshooting page #354

Merged
merged 1 commit into from
Nov 9, 2023

Conversation

One234Fi
Copy link
Contributor

@One234Fi One234Fi commented Nov 8, 2023

Fixed various punctuation and spelling issues on the troubleshooting page. Also performed minor grammar edits.

I tried not to change the actual meaning of sentences, but please let me know if I misunderstood the intent of a sentence and need to revert or update it.

@One234Fi
Copy link
Contributor Author

One234Fi commented Nov 9, 2023

Hi recp,

I'm new to contribution and didn't think to ask before opening the PR:

If I propose more revisions for the docs in the future, is it better to batch the changes into one PR after im finished, or should I open a new PR per set of changes?

Basically, I'm asking if PRs here should be split up by unit of work or split by topic of work.

@recp recp merged commit 58a4b47 into recp:master Nov 9, 2023
1 check passed
@recp
Copy link
Owner

recp commented Nov 9, 2023

Hi @One234Fi,

For documentation, it's more manageable to combine small, related changes into one PR. For larger changes, separate PRs by topic can be helpful.

Thanks for your contributions, the PR is merged 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants