Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@location-state/conform impl #346

Merged
merged 10 commits into from
May 13, 2024
Merged

@location-state/conform impl #346

merged 10 commits into from
May 13, 2024

Conversation

@AkifumiSato AkifumiSato requested a review from koichik May 10, 2024 04:51
Copy link

changeset-bot bot commented May 10, 2024

🦋 Changeset detected

Latest commit: f116bde

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@location-state/conform Major
@location-state/core Minor
@location-state/next Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

AkifumiSato and others added 7 commits May 13, 2024 10:24
* examples: confrom init

* example: conform example: use src directory, add next.config.js

* example: conform example's remove button not working

---------

Co-authored-by: akfm.sato <01047245@CF0286.local>
* example: confrom wrapper module

* example: restore location state form

* example: refactor useLocationForm type

* example: useLocationForm return with form props

* example: refactor&comment useLocationForm

* example: fix state name

* example: useForm behavoir test

* example: useLocationForm refactor rm typeof window

* example: useLocationForm fix return value

* example: fix useSyncExternalStore 1st arg same ref

* example: dynamic form item restore

* example: useLocationForm with dynamic form

* example: fix effect callback to useEffect

* example: getLocationFormProps memo

* feat: useLocationGetState impl

* example: useLocationForm with getLocationState

* example: fix onChange save location state

* example: @types/lodash.set add

* example: rm (dynamic)

* example: useLocationFrom option add id

* example: fix useLocationFrom checkbox restore

* example: useLocationForm add comment

* example: useLocationForm refactor noop name

* example: rm unused import

* example: (not use location state) conform search form

* example: useLocationForm sync url exmaple

* example: url useLocationForm example

* example: fix useLocationForm onChange default value

* example: refactor package, key

* example: useLocationForm refactor

* example: useLocationForm rendering optimize

* rebase on conform branch, update lock file

* example: useLocationForm callback deps fix

* refactor: useLocationForm option idPrefix rename

* feat: useLocationForm API fix

* fix: useLocationForm type

* refactor: useLocationForm re-render hooks useReducer

* refactor: useLocationForm add ref guard check

* fix: useLocationForm formOption fix

* feat: `filterFormValueWihZodShape` add

* fix: useLocationForm id setting timing

* fix: useLocationForm initial id set

* refactor: filterFormValueWihZodShape no use zod

* fix: useLocationForm inital id set

* fix: useLocationForm schema option add

* refactor: rename useLocationForm inner vars

* test: conform example e2e add

* example: useLocationForm option rm shape

* example: rename static form

* example: simple form with conform

* refactor: vars order fix

* refactor: fix defenition order

* feat: `useLocationKey` impl

* example: refactor rm lodash.set

* refactor: useLocationForm

* refactor: updateWithObjectPath

* example: type spec simple form

* example: simple conform submit redirect

* refactor: declarative order

* refactor: rename inner vars

* refactor: getPaths

* refactor: useLocationKey subscribe

* feat: useLocationKey option

* todo comment

* fix: useLocationKey default args

* fix: useLocationForm support intent

* refactor: useLocationForm console rm

* fix: simple form unnecessary if rm

* example: dynamic form add first button

* example: number's error field

* example: refactor schema

* fix: conform example test

* example: simple-form refactor

* example: static-from refactor

* refactor: useLocationForm

* example: simple/static form content

* example: test comment fix

* example: fix number error message

* example: dynamic form reset button impl

* example: submit/reset button layout

* example: rename schema

* refactor: conform page

---------

Co-authored-by: akfm.sato <01047245@CF0286.local>
Co-authored-by: akfm.sato <01047245@CF0286.local>
* feat: @location-state/conform init

* refactor: confrom src directory

* refactor: @location-state/confrom strict check

* refactor: updatedWithObjectPath test

* refactor: updatedWithObjectPath

* refactor: updateWithObjectPath

* refactor: useLocationForm

* refactor: updatedWithObjectPath type assert refactor

* refactor: @repo/utils, @repo/test-utils

* refactor: rename configs to @repo/configs

* refactor: rename test case

* refactor: type utils

* feat: useLocationForm use valibot validation

* refactor: add comment

* fix: @location-state/confrom package.json fix description/dependencies

* refactor: updateWithObjectPath test

* refactor: format

* tsconfig update

* feat: @location-state/conform dependencies/description fix

* refactor: move comment to schema.ts

* refactor: test define member order fix

* refactor: comment fix, AssertError impl

* test: @location-state/conform test

* refactor: @location-state/conform array utils impl

* refactor: update-array test

* refactor: update-array test name fix

---------

Co-authored-by: akfm.sato <01047245@CF0286.local>
* docs: `@location-state/conform` README

* docs: `@location-state/conform` API docs

* docs: `@location-state/confrom` docs fix

* docs: `@location-state/conform` fix Quickstart text

* docs: `@location-state/conform` example of Server Actions or nothing.

* docs: `@location-state/conform` useLocationForm type fix

* docs: `@location-state/conform` add conform's `id` link.

* docs: `@location-state/conform` fix useLocationForm return text.

* docs: `@location-state/conform` fix GetLocationFormProps return text.

* docs: `@location-state/conform` fix GetLocationFormProps return text.

* docs: `@location-state/conform` fix feature explain.

* docs: `@location-state/conform` fix API explain.

---------

Co-authored-by: akfm.sato <01047245@CF0286.local>
Co-authored-by: akfm.sato <01047245@CF0286.local>
* docs: add changeset of `@location-state/conform`.

* docs: `useLocationKey`, `useLocationGetState` explain API docs.

* docs: fix changesets.

* docs: split changesets docs

* docs: fix `useLocationKey` / `useLocationGetState`

* docs: fix `useLocationGetState`/``useLocationKey` description word.

* chore: pnpm update version specify

---------

Co-authored-by: akfm.sato <01047245@CF0286.local>
@AkifumiSato
Copy link
Collaborator Author

AkifumiSato commented May 13, 2024

pnpmのバージョン指定が甘かったのと、多分rebase時に@repo/configsの依存が消えてたので修正しました。
78243c7

koichik

This comment was marked as resolved.

Copy link
Member

@koichik koichik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです!!乙でした!!

@AkifumiSato AkifumiSato merged commit 0bad20c into main May 13, 2024
2 checks passed
@AkifumiSato AkifumiSato deleted the conform branch May 13, 2024 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants