[Php80] Skip not match property hook type with parameter type on ClassPropertyAssignToConstructorPromotionRector (#7109)

samsonasik · web-flow · commit 34b45d451d7b · 2025-08-05T21:32:20.000+07:00
* [Php80] Skip not match property hook type with parameter type on ClassPropertyAssignToConstructorPromotionRector

* eol

* fix per use case
diff --git a/rules-tests/Php80/Rector/Class_/ClassPropertyAssignToConstructorPromotionRector/Fixture/skip_not_match_property_hook_type.php.inc b/rules-tests/Php80/Rector/Class_/ClassPropertyAssignToConstructorPromotionRector/Fixture/skip_not_match_property_hook_type.php.inc
@@ -0,0 +1,17 @@
+<?php
+
+namespace Rector\Tests\Php80\Rector\Class_\ClassPropertyAssignToConstructorPromotionRector\Fixture;
+
+class SkipNotMatchPropertyHookType {
+    protected \stdClass $origin {
+        set(array|\stdClass $origin) {
+            $this->origin = is_array($origin) ? (object) $origin : clone $origin;
+        }
+    }
+
+    public function __construct(
+        array|\stdClass $origin
+    ) {
+        $this->origin = $origin;
+    }
+}
diff --git a/rules/Php80/Rector/Class_/ClassPropertyAssignToConstructorPromotionRector.php b/rules/Php80/Rector/Class_/ClassPropertyAssignToConstructorPromotionRector.php
@@ -206,6 +206,13 @@ public function refactor(Node $node): ?Node
                 continue;
             }
 
+            if ($property->type instanceof Node
+                && $param->type instanceof Node
+                && $property->hooks !== []
+                && ! $this->nodeComparator->areNodesEqual($property->type, $param->type)) {
+                continue;
+            }
+
             $hasChanged = true;
 
             // remove property from class
