[CodeQuality] Skip parent::class usage on GetClassToInstanceOfRector (#…

…1994)

rules-tests/CodeQuality/Rector/Identical/GetClassToInstanceOfRector/Fixture/skip_parent_usage.php.inc

@@ -0,0 +1,13 @@
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\Identical\GetClassToInstanceOfRector\Fixture;
+
+class SkipParentUsage extends SomeParent {
+    public function test(object $other) {
+       var_dump(parent::class);
+       var_dump(get_class($other) === parent::class);
+       var_dump($other instanceof parent);
+    }
+}
+
+(new SkipParentUsage())->test(new SkipParentUsage());

rules-tests/CodeQuality/Rector/Identical/GetClassToInstanceOfRector/Source/SomeParent.php

@@ -0,0 +1,7 @@
+<?php
+
+namespace Rector\Tests\CodeQuality\Rector\Identical\GetClassToInstanceOfRector\Source;
+
+class SomeParent
+{
+}

rules/CodeQuality/Rector/Identical/GetClassToInstanceOfRector.php

@@ -15,6 +15,7 @@
 use PhpParser\Node\Name;
 use PhpParser\Node\Name\FullyQualified;
 use PhpParser\Node\Scalar\String_;
+use Rector\Core\Enum\ObjectReference;
 use Rector\Core\NodeManipulator\BinaryOpManipulator;
 use Rector\Core\Rector\AbstractRector;
 use Rector\Php71\ValueObject\TwoNodeMatch;
@@ -98,6 +99,10 @@ public function refactor(Node $node): ?Node
             return null;
         }
 
+        if ($className === ObjectReference::PARENT()->getValue()) {
+            return null;
+        }
+
         $class = in_array($className, self::NO_NAMESPACED_CLASSNAMES, true)
             ? new Name($className)
             : new FullyQualified($className);