Remove deprecated ParamTypeDeclarationRector, that treated docs as strict types to keep type declaration set reliable #3111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomasVotruba
force-pushed
the
tv-add-array-docs
branch
5 times, most recently
from
29c6308
to
e812764
Compare
…rict types to keep type declaration set reliable
TomasVotruba
force-pushed
the
tv-add-array-docs
branch
2 times, most recently
from
9fead1a
to
cd998db
Compare
TomasVotruba
force-pushed
the
tv-add-array-docs
branch
from
cd998db
to
f8b847f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ParamTypeDeclarationRectoris deprecated for a couple of months.It caused many errors, as it moved any docblock to strict type declaration. This turned this rule to stream of fatal errors.
Instead, this rule was split into many smaller type resolvers, that are working with existing strict type declarations and are much more reliable 👍 Use those instead, e.g. via
SetList::TYPE_DECLARATIONset.