[TypeDeclaration] Remove unused intersection docblock on nullable int…

…ersection on TypedPropertyFromAssignsRector (#3373)
rectorphp · Feb 12, 2023 · 91ddd68 · 91ddd68
1 parent db4ec02
commit 91ddd68
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 5 deletions.
diff --git a/...rty/TypedPropertyFromAssignsRector/FixtureComplexTypes/nullable_intersection_type.php.inc b/...rty/TypedPropertyFromAssignsRector/FixtureComplexTypes/nullable_intersection_type.php.inc
@@ -33,9 +33,6 @@ use PHPUnit\Framework\TestCase;
 
 class NullableIntersectionType extends TestCase
 {
-    /**
-     * @var DateTime&MockObject
-     */
     private (\DateTime&\PHPUnit\Framework\MockObject\MockObject)|null $property = null;
 
     public function testExample(): void

diff --git a/rules/DeadCode/PhpDoc/DeadVarTagValueNodeAnalyzer.php b/rules/DeadCode/PhpDoc/DeadVarTagValueNodeAnalyzer.php
@@ -6,7 +6,6 @@
 
 use PhpParser\Node\Stmt\Property;
 use PHPStan\PhpDocParser\Ast\PhpDoc\VarTagValueNode;
-use PHPStan\Type\IntersectionType;
 use PHPStan\Type\UnionType;
 use Rector\NodeTypeResolver\TypeComparator\TypeComparator;
 use Rector\StaticTypeMapper\StaticTypeMapper;
@@ -29,7 +28,7 @@ public function isDead(VarTagValueNode $varTagValueNode, Property $property): bo
         $propertyType = $this->staticTypeMapper->mapPhpParserNodePHPStanType($property->type);
         $docType = $this->staticTypeMapper->mapPHPStanPhpDocTypeNodeToPHPStanType($varTagValueNode->type, $property);
 
-        if ($propertyType instanceof UnionType && ! $docType instanceof UnionType && ! $docType instanceof IntersectionType) {
+        if ($propertyType instanceof UnionType && ! $docType instanceof UnionType) {
             return true;
         }