Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump min PHP to 8, cleanup readmes #1

Merged
merged 4 commits into from May 10, 2021
Merged

Bump min PHP to 8, cleanup readmes #1

merged 4 commits into from May 10, 2021

Conversation

TomasVotruba
Copy link
Member

No description provided.

@TomasVotruba TomasVotruba changed the title bump php 8 Bump min PHP to 8, cleanup readmes May 10, 2021
@TomasVotruba TomasVotruba merged commit 1a88977 into main May 10, 2021
@TomasVotruba TomasVotruba deleted the bump-php-8 branch May 10, 2021 18:00
staabm pushed a commit that referenced this pull request Aug 7, 2021
staabm pushed a commit that referenced this pull request Aug 16, 2021
staabm added a commit that referenced this pull request Aug 16, 2021
* introduce PlatformAgnosticAssertions which handle cross platform issues

* Update packages-tests/FileFormatter/ValueObject/NewLineTest.php

* apply PlatformAgnosticAssertions on MoveValueObjectsToValueObjectDirectoryRectorTest

* use PlatformAgnosticAssertions in AbstractTestCase

* Github Actions: run tests on windows-latest and ubuntu-latest

* added PlatformAgnosticAssertions::assertStringEqualsFile()

* Ensure tests manually tear down props (#1)

* check for windows or linux line ending. \n is contained in both.

* support assertFileEquals() normalizing

* add OS to name, to separate

* fixed windows compat in VendorLocationDetector

* ParentClassMethodTypeOverrideGuard: fixed windows-compat

* ClassMethodParamVendorLockResolver: windows compat

* Docs

* Update PlatformAgnosticAssertions.php

* Delete tests.yaml

* Create tests.yaml

Co-authored-by: Markus Staab <m.staab@complex-it.de>
Co-authored-by: Markus Staab <maggus.staab@googlemail.com>
Co-authored-by: Markus Staab <markus.staab@redaxo.de>
Co-authored-by: Dan <dpock32509@gmail.com>
samsonasik added a commit that referenced this pull request Nov 1, 2021
samsonasik added a commit that referenced this pull request Nov 1, 2021
samsonasik added a commit that referenced this pull request Nov 1, 2021
samsonasik added a commit that referenced this pull request Nov 1, 2021
samsonasik added a commit that referenced this pull request Nov 1, 2021
TomasVotruba pushed a commit that referenced this pull request Nov 1, 2021
…PHPStan\Analyser\Scope, null given (#1120)

Co-authored-by: GitHub Action <action@github.com>
samsonasik added a commit that referenced this pull request Nov 10, 2021
…ant\ConstantIntegerType::__construct(): Argument #1 ($value) must be of type int, string given
TomasVotruba pushed a commit that referenced this pull request Nov 11, 2021
…ant\ConstantIntegerType::__construct(): Argument #1 ($value) must be of type int, string given (#1210)

* [NodeTypeResolver] Avoid error Uncaught TypeError: PHPStan\Type\Constant\ConstantIntegerType::__construct(): Argument #1 ($value) must be of type int, string given

* final touch: ensure cast to (string) for ConstantStringType
TomasVotruba added a commit that referenced this pull request Nov 28, 2021
TomasVotruba added a commit that referenced this pull request Apr 25, 2022
Co-authored-by: GitHub Action <action@github.com>
mfrieling added a commit to mfrieling/rector-src that referenced this pull request Feb 21, 2023
The failed check is not at all related to the changes of #7795 or rectorphp#3398, but prevents CI from passing here:

Rector\Tests\TypeDeclaration\Rector\ClassMethod\AddMethodCallBasedStrictParamTypeRector\IntersectionTest::test with data set Bump min PHP to 8, cleanup readmes rectorphp#1 Failed asserting that string matches format description.
mfrieling added a commit to mfrieling/rector-src that referenced this pull request Feb 22, 2023
The failed check is not at all related to the changes of #7795 or rectorphp#3398, but prevents CI from passing here:

Rector\Tests\TypeDeclaration\Rector\ClassMethod\AddMethodCallBasedStrictParamTypeRector\IntersectionTest::test with data set Bump min PHP to 8, cleanup readmes rectorphp#1 Failed asserting that string matches format description.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant