-
-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Php70][Visibility] Avoid error Argument #1 ($scope) must be of type PHPStan\Analyser\Scope, null given #1120
Conversation
CI error seems unrelated. |
f56e077
to
e146992
Compare
08b9cf4
to
45034b7
Compare
@TomasVotruba it seems ready for merge, CI error is unrelated. |
…PHPStan\Analyser\Scope, null given
81e4fcf
to
5f3a6a1
Compare
Thank you 👍 I've fixed the CI to comply with Symplify removal of symfony/http-kernel - see deprecated-packages/symplify#3726 |
@TomasVotruba there is still 1 test error: There was 1 error:
1) Rector\Tests\TypeDeclaration\Rector\ClassMethod\AddArrayReturnDocTypeRector\AddArrayReturnDocTypeRectorTest::test with data set #23 (Symplify\SmartFileSystem\SmartFileInfo Object (...))
PHPStan\Broker\ClassAutoloadingException: Class Symfony\Component\HttpKernel\Bundle\BundleInterface not found. Do you think we need to create stub for |
I added stub for |
it seems define empty interface BundleInterface is make it works |
That's exactly the right solution 👍 |
I tried to apply latest
"rector/rector": "dev-main"
for use PHPStan 1.0, and got error into CodeIgniter project to test compatibilty early codeigniter4/CodeIgniter4#5269 and got error:this patch fix it.