[Php70][Visibility] Avoid error Argument #1 ($scope) must be of type PHPStan\Analyser\Scope, null given

[samsonasik]

I tried to apply latest "rector/rector": "dev-main" for use PHPStan 1.0, and got error into CodeIgniter project to test compatibilty early codeigniter4/CodeIgniter4#5269 and got error:

Error: ] Could not process "system/CodeIgniter.php" file, due to:               
         "Rector\NodeCollector\ScopeResolver\ParentClassScopeResolver::resolvePa
         rentClassName(): Argument #1 ($scope) must be of type                  
         PHPStan\Analyser\Scope, null given, called in                          
         vendor/rector/rector/rules/Php70/Rector/StaticCall/StaticCallOnNonStati
         cToInstanceCallRector.php:152". On line: 10    

this patch fix it.

[samsonasik]

CI error seems unrelated.

[samsonasik]

@TomasVotruba it seems ready for merge, CI error is unrelated.

[TomasVotruba]

Thank you 👍

I've fixed the CI to comply with Symplify removal of symfony/http-kernel - see deprecated-packages/symplify#3726
Should be ✔️ now

[samsonasik]

@TomasVotruba there is still 1 test error:

 There was 1 error:

1) Rector\Tests\TypeDeclaration\Rector\ClassMethod\AddArrayReturnDocTypeRector\AddArrayReturnDocTypeRectorTest::test with data set #23 (Symplify\SmartFileSystem\SmartFileInfo Object (...))
PHPStan\Broker\ClassAutoloadingException: Class Symfony\Component\HttpKernel\Bundle\BundleInterface not found.

Do you think we need to create stub for BundleInterface or we can require --dev symfony/http-kernel?

[samsonasik]

I added stub for BundleInterface d4ffaf1

[samsonasik]

it seems define empty interface BundleInterface is make it works

[TomasVotruba]

it seems define empty interface BundleInterface is make it works

That's exactly the right solution 👍