-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PHPStan] Upgrade to PHPStan 1.0 #5269
Merged
samsonasik
merged 10 commits into
codeigniter4:develop
from
samsonasik:upgrade-to-phpstan1
Nov 10, 2021
Merged
[PHPStan] Upgrade to PHPStan 1.0 #5269
samsonasik
merged 10 commits into
codeigniter4:develop
from
samsonasik:upgrade-to-phpstan1
Nov 10, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ignoring new PHPStan errors for now so we can verify next one by one. |
samsonasik
requested review from
MGatner,
paulbalandan and
kenjis
and removed request for
MGatner
November 1, 2021 09:18
MGatner
requested changes
Nov 1, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I expect all the Rector changes are due to dependency incompatibilities, but is there a way we can split this out into separate PRs?
samsonasik
commented
Nov 1, 2021
1 task
samsonasik
force-pushed
the
upgrade-to-phpstan1
branch
from
November 1, 2021 21:34
98b1dfd
to
519b115
Compare
samsonasik
force-pushed
the
upgrade-to-phpstan1
branch
from
November 9, 2021 12:28
519b115
to
c19875c
Compare
@MGatner @paulbalandan All green 🎉 |
kenjis
approved these changes
Nov 10, 2021
MGatner
approved these changes
Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading to PHPStan 1.0, Apply rector
dev-main
before next release.Checklist: