Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PHPStan] Upgrade to PHPStan 1.0 #5269

Merged
merged 10 commits into from
Nov 10, 2021

Conversation

samsonasik
Copy link
Member

@samsonasik samsonasik commented Nov 1, 2021

Upgrading to PHPStan 1.0, Apply rector dev-main before next release.

Checklist:

  • Securely signed commits

@samsonasik
Copy link
Member Author

samsonasik commented Nov 1, 2021

ignoring new PHPStan errors for now so we can verify next one by one.

Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expect all the Rector changes are due to dependency incompatibilities, but is there a way we can split this out into separate PRs?

phpstan.neon.dist Show resolved Hide resolved
@samsonasik
Copy link
Member Author

@MGatner @paulbalandan All green 🎉

@samsonasik samsonasik merged commit 3acddb6 into codeigniter4:develop Nov 10, 2021
@samsonasik samsonasik deleted the upgrade-to-phpstan1 branch November 10, 2021 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants