Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test expectations #3837

Merged
merged 1 commit into from
May 14, 2023
Merged

Update test expectations #3837

merged 1 commit into from
May 14, 2023

Conversation

staabm
Copy link
Contributor

@staabm staabm commented May 14, 2023 •
edited
Loading

because of rectorphp/rector-phpunit#173 we need to adjust test expectations to make the build green again.

this one took a while to get behind it :)

samsonasik
samsonasik approved these changes May 14, 2023
View reviewed changes
Copy link
Member

@samsonasik samsonasik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is due to rector-phpunit update:

@staabm staabm marked this pull request as ready for review May 14, 2023 09:27
@staabm staabm requested a review from TomasVotruba as a code owner May 14, 2023 09:27
@samsonasik samsonasik enabled auto-merge (squash) May 14, 2023 09:27
@samsonasik
Copy link
Member

Thank you @staabm

@samsonasik samsonasik merged commit 6482c59 into rectorphp:main May 14, 2023
41 checks passed
@staabm staabm mentioned this pull request May 14, 2023
Merged
@staabm staabm deleted the exp branch May 14, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samsonasik samsonasik samsonasik approved these changes

@TomasVotruba TomasVotruba Awaiting requested review from TomasVotruba

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@staabm @samsonasik