Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Util] Introduce FileHasher #3833

Merged
merged 7 commits into from
May 14, 2023
Merged

[Util] Introduce FileHasher #3833

merged 7 commits into from
May 14, 2023

Conversation

staabm
Copy link
Contributor

@staabm staabm commented May 14, 2023

1:1 extracted from #3809 to make it smaller

@staabm
Copy link
Contributor Author

staabm commented May 14, 2023

guess the failling test is related to some PR merged to master, not this one?

1) Rector\Tests\Arguments\Rector\RectorOrder\RectorOrderTest::test with data set #0
Failed on fixture file "fixture.php.inc"
Failed asserting that string matches format description.
--- Expected
+++ Actual
@@ @@
 {
     public function test()
     {
-        $this->assertContains('f', 'foo');
-        $this->assertContains('f', 'foo');
+        $this->assertStringContainsString('f', 'foo');
+        $this->assertStringContainsString('f', 'foo');
 
-        $this->assertContains('oauth_body_hash', $headers['Authorization'][0]);
+        $this->assertStringContainsString('oauth_body_hash', $headers['Authorization'][0]);
     }
 }

/home/runner/work/rector-src/rector-src/packages/Testing/PHPUnit/AbstractRectorTestCase.php:178
/home/runner/work/rector-src/rector-src/packages/Testing/PHPUnit/AbstractRectorTestCase.php:131
/home/runner/work/rector-src/rector-src/rules-tests/Arguments/Rector/RectorOrder/RectorOrderTest.php:19


just confirmed I get this error also on the master branch


Update: Fixed in #3837

src/Util/FileHasher.php Outdated Show resolved Hide resolved
packages/Testing/PHPUnit/AbstractTestCase.php Show resolved Hide resolved
src/Util/FileHasher.php Show resolved Hide resolved
@staabm staabm changed the title Introduce FileHasher [Util] Introduce FileHasher May 14, 2023
config/config.php Outdated Show resolved Hide resolved
config/config.php Outdated Show resolved Hide resolved
@samsonasik
Copy link
Member

Thank you @staabm

@samsonasik samsonasik merged commit 7a32610 into rectorphp:main May 14, 2023
@staabm staabm deleted the hasher branch May 14, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants