Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DeadCode] Mirror comment on assign method call on RemoveUnusedVariableAssignRector #5195

Merged
merged 3 commits into from
Oct 24, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
<?php

namespace Rector\Tests\DeadCode\Rector\Assign\RemoveUnusedVariableAssignRector\Fixture;

final class MirrorCommentAssignMethodCall
{
public function run($db)
{
// execute query
$value = $db->query();
}
}

?>
-----
<?php

namespace Rector\Tests\DeadCode\Rector\Assign\RemoveUnusedVariableAssignRector\Fixture;

final class MirrorCommentAssignMethodCall
{
public function run($db)
{
// execute query
$db->query();
}
}

?>
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,9 @@ public function refactorWithScope(Node $node, Scope $scope): ?ClassMethod
if ($this->hasCallLikeInAssignExpr($assign, $scope)) {
// clean safely
$cleanAssignedExpr = $this->cleanCastedExpr($assign->expr);
$node->stmts[$stmtPosition] = new Expression($cleanAssignedExpr);
$newExpression = new Expression($cleanAssignedExpr);
$this->mirrorComments($newExpression, $currentStmt);
$node->stmts[$stmtPosition] = $newExpression;
} else {
unset($node->stmts[$stmtPosition]);
}
Expand Down