Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature idea: Add the Symfony\Component\Console\Attribute\AsCommand attribute #159

Closed
stephanvierkant opened this issue May 2, 2022 · 1 comment · Fixed by #163
Closed

Feature idea: Add the Symfony\Component\Console\Attribute\AsCommand attribute #159

stephanvierkant opened this issue May 2, 2022 · 1 comment · Fixed by #163

Comments

@stephanvierkant
Copy link
Contributor

As of Symfony 6.1, I've got this notification in my logs:

Since symfony/console 6.1: Relying on the static property "$defaultDescription" for setting a command description is deprecated. Add the "Symfony\Component\Console\Attribute\AsCommand" attribute to the "App\Command\NotificationCommand" class instead.

I'd the great if Rector can refactor commands with static $defaultName and static $defaultDescription.
@TomasVotruba
Copy link
Member

Hi, seems useful feature.
Could you send PR proposal to talk over?

@stephanvierkant stephanvierkant mentioned this issue May 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add CommandPropertyToAttributeRector stephanvierkant/rector-symfony
2 participants
@stephanvierkant @TomasVotruba