Incorrect behavior of ReadOnlyPropertyRector, MakeTypedPropertyNullableIfCheckedRector

[Wohlie]

Bug Report

Subject	Details
Rector version	last dev-main
Installed as	composer dependency

Minimal PHP Code Causing Issue

See https://getrector.org/demo/1f0af0d6-cd51-4f66-a14d-8e5b3e1797f6

<?php

 final class SomeClass
 {
     private AnotherClass $anotherClass;

     public function run()
     {
         if ($this->anotherClass === null) {
             return null;
         }
     }
 }

Responsible rules

• ReadOnlyPropertyRector

• MakeTypedPropertyNullableIfCheckedRector

Expected Behavior

The property anotherClass can't be read only, because read only properties can't have a default value.

With the refactored code, you will get a Fatal error: Readonly property SomeClass::$anotherClass cannot have default value exception: https://3v4l.org/Ke5Jc

[samsonasik]

The original code seems already fatal error, see https://3v4l.org/Ke5Jc

[Wohlie]

Yes, but you will get another error.

If you change the order of the rules, the output is correct, with no default value:
https://getrector.org/demo/843629aa-01d0-4738-8f0a-59672231e748

You can also use the following code snipped:
https://getrector.org/demo/670db2f0-3ed9-4c8a-95dd-f0ae2d59621a