Fix empty name in @Route #3246
Fix empty name in @Route #3246
Conversation
TomasVotruba
commented
Apr 24, 2020
•
TomasVotruba
commented
- Closes Symfony route with prefix #3240
- Closes Rector removes empty name from @Route annotation #3234
| @@ -118,9 +118,8 @@ public function __toString(): string | |||
| 'path' => $this->printValueWithOptionalQuotes('path', $this->path, $this->localizedPaths), | |||
| ]; | |||
|
|
|||
| if ($this->name) { | |||
There was a problem hiding this comment.
Maybe if ($this->name !== null) {? A name attribute isn't required, but can be empty.
It fixes this bug, but I'm not sure about side effects.
There was a problem hiding this comment.
I'm not sure if annotation parser from Doctrine makes any difference about these 2 cases.
Why do you need empty attribute?
There was a problem hiding this comment.
That's the point of this issue, isn't it? Name may be empty, but in this case an empty name is removed.
There was a problem hiding this comment.
I mean why do you need empty attribute in your code?
$this->redirect('')It might not be technically possible to differentiate, so if that has no effect, it should be removed in your code.
There was a problem hiding this comment.
No, a method @Route can have an empty name ("", not null) if the class @Route has a name.
There was a problem hiding this comment.
How can you use that compared to removing the attribute?
There was a problem hiding this comment.
I'm not sure I understand you correctly.
When you remove the name attribute from a method, the method is removed from routing. It should be empty, not removed. See my example: https://github.com/rectorphp/rector/pull/3240/files
That file contains valid code and should'nt be changed.
|
Replaced by #3248 |
rectorphp/rector-src@6bd6b3c PHP80 string helpers loose comparison (#3246)
