Pricing multiple adjustments #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbrudner
force-pushed
the
pricing-multiple-adjustments
branch
from
6d70bb9
to
7b985b3
Compare
dbrudner
force-pushed
the
release/pricing
branch
from
545f49d
to
24869db
Compare
dbrudner
force-pushed
the
pricing-multiple-adjustments
branch
from
7b985b3
to
d22345e
Compare
Pull Request Test Coverage Report for Build 299c089fd607af5c8b1196f19ac0834cd8101c38-PR-14
💛 - Coveralls |
dbrudner
force-pushed
the
pricing-multiple-adjustments
branch
from
d22345e
to
b5f1fd1
Compare
| {recurlyError ? <span style={{ color: 'red' }}>{recurlyError.message}</span> : ''} | ||
| {price && price.now && !recurlyError ? <span>Subtotal: ${price.now.subtotal}</span> : ''} | ||
| </div> | ||
| <button>Calculate subtotal</button> |
There was a problem hiding this comment.
Is there a way to trigger recalculation onChange of any input without having to pepper onChange bindings throughout? I think that would be a more useful UX to demonstrate.
There was a problem hiding this comment.
We can create a reusable input component for something like this. My intention was to abstract as little as possible, but the demo is definitely getting long and verbose.
There was a problem hiding this comment.
I also think the demo generally needs some love. I'm thinking a separate PR everything else is merged in to clean up some demo-specific stuff is needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.