Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs Fix: useRecurly Paypal example #156

Merged
merged 1 commit into from
Oct 8, 2021
Merged

Conversation

javimbk
Copy link
Contributor

@javimbk javimbk commented Oct 8, 2021

While going through the docs I saw a little typo on the Paypal example of the usage of useRecurly.

This PR addresses that in order to be the right one like in the rest of the docs where it's not wrong.

@javimbk javimbk changed the title fix: useRecurly destructuring on Paypal example Docs Fix: useRecurly Paypal example Oct 8, 2021
@coveralls
Copy link

Pull Request Test Coverage Report for Build 777

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 98.944%

Totals Coverage Status
Change from base Build 764: 0.0%
Covered Lines: 221
Relevant Lines: 221

💛 - Coveralls

@rer7891
Copy link
Contributor

rer7891 commented Oct 8, 2021

@javimbk Thanks again for making this contribution. We will be reviewing and get back to you as soon as possible.

@rer7891 rer7891 merged commit 980b4f7 into recurly:main Oct 8, 2021
@rer7891
Copy link
Contributor

rer7891 commented Oct 8, 2021

@javimbk Thanks again for the contribution. We were able to get these reviewed and merged quickly. As always feel free to bring any issues you find to our attention.

@javimbk javimbk deleted the patch-1 branch October 11, 2021 07:56
@javimbk
Copy link
Contributor Author

javimbk commented Oct 11, 2021

Thank you @rer7891 , I'll make sure to do so!

recurly-integrations pushed a commit that referenced this pull request Oct 27, 2022
[Full Changelog](v1.2.4...v1.2.5)

**Merged Pull Requests**

- listen_for_attach_event [#187](#187) ([smagdicatrecurly](https://github.com/smagdicatrecurly))
- Adds demo for automated focus shift on individual card Elements [#183](#183) ([chrissrogers](https://github.com/chrissrogers))
- setup element when didmount [#182](#182) ([WillXing](https://github.com/WillXing))
- Docs fix: UseCheckoutPricingInput `subscriptions` [#157](#157) ([javimbk](https://github.com/javimbk))
- Docs Fix: useRecurly Paypal example [#156](#156) ([javimbk](https://github.com/javimbk))
- Revert "add security to github CODEOWNER file" [#147](#147) ([eternal44](https://github.com/eternal44))
- add security to github CODEOWNER file [#142](#142) ([eternal44](https://github.com/eternal44))
- fix(lib/provider.js): fix RecurlyProvider throwing error when fraud property is set [#123](#123) ([mikeedwards](https://github.com/mikeedwards))
recurly-integrations pushed a commit that referenced this pull request Oct 27, 2022
[Full Changelog](v1.2.4...v1.2.6)

**Merged Pull Requests**

- listen_for_attach_event [#187](#187) ([smagdicatrecurly](https://github.com/smagdicatrecurly))
- Adds demo for automated focus shift on individual card Elements [#183](#183) ([chrissrogers](https://github.com/chrissrogers))
- setup element when didmount [#182](#182) ([WillXing](https://github.com/WillXing))
- Docs fix: UseCheckoutPricingInput `subscriptions` [#157](#157) ([javimbk](https://github.com/javimbk))
- Docs Fix: useRecurly Paypal example [#156](#156) ([javimbk](https://github.com/javimbk))
- Revert "add security to github CODEOWNER file" [#147](#147) ([eternal44](https://github.com/eternal44))
- add security to github CODEOWNER file [#142](#142) ([eternal44](https://github.com/eternal44))
- fix(lib/provider.js): fix RecurlyProvider throwing error when fraud property is set [#123](#123) ([mikeedwards](https://github.com/mikeedwards))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants