-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds Bacs Support #608
Merged
Merged
Adds Bacs Support #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calebbarde
force-pushed
the
add_bacs_support
branch
from
June 2, 2020 18:51
8c2baff
to
838fd0f
Compare
chrissrogers
reviewed
Jun 2, 2020
calebbarde
force-pushed
the
add_bacs_support
branch
from
June 3, 2020 17:12
838fd0f
to
3122bc1
Compare
glaubenstein
approved these changes
Jun 3, 2020
chrissrogers
requested changes
Jun 4, 2020
recurly.bankAccount.bankInfo({ routingNumber: 'test-routing-number' }, (err, bankInfo) => { | ||
assert.deepEqual(bankInfo, { bank_name: 'test-bank-name' }); | ||
assert(!err); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome unit tests 👍
calebbarde
force-pushed
the
add_bacs_support
branch
from
June 4, 2020 15:10
3122bc1
to
0c34405
Compare
calebbarde
force-pushed
the
add_bacs_support
branch
from
June 11, 2020 16:43
e318186
to
94d9901
Compare
calebbarde
force-pushed
the
add_bacs_support
branch
2 times, most recently
from
June 19, 2020 14:55
5d0c828
to
906702b
Compare
calebbarde
force-pushed
the
add_bacs_support
branch
from
June 22, 2020 20:44
906702b
to
3fb6e10
Compare
chrissrogers
approved these changes
Jun 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Bacs in Recurly JS.