Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Bacs Support #608

Merged
merged 3 commits into from
Jun 23, 2020
Merged

Adds Bacs Support #608

merged 3 commits into from
Jun 23, 2020

Conversation

calebbarde
Copy link
Contributor

This PR adds support for Bacs in Recurly JS.

@coveralls
Copy link

coveralls commented Jun 2, 2020

Coverage Status

Coverage decreased (-0.02%) to 93.184% when pulling 3fb6e10 on add_bacs_support into 2e31544 on master.

@chrissrogers chrissrogers changed the title Support Bacs on RJS Adds BACS Support Jun 3, 2020
lib/recurly/bank-account.js Outdated Show resolved Hide resolved
test/e2e/recurly.test.js Outdated Show resolved Hide resolved
recurly.bankAccount.bankInfo({ routingNumber: 'test-routing-number' }, (err, bankInfo) => {
assert.deepEqual(bankInfo, { bank_name: 'test-bank-name' });
assert(!err);
});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome unit tests 👍

test/e2e/recurly.test.js Show resolved Hide resolved
test/e2e/recurly.test.js Outdated Show resolved Hide resolved
@chrissrogers chrissrogers changed the title Adds BACS Support Adds Bacs Support Jun 4, 2020
@calebbarde calebbarde force-pushed the add_bacs_support branch 2 times, most recently from 5d0c828 to 906702b Compare June 19, 2020 14:55
@chrissrogers chrissrogers merged commit 1bf8bae into master Jun 23, 2020
@chrissrogers chrissrogers deleted the add_bacs_support branch June 23, 2020 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants