-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding challenge window size selections #757
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tilley-kyle
force-pushed
the
3ds-window-sizing
branch
from
October 6, 2022 21:56
1a99f10
to
25c84b2
Compare
douglaslise
previously approved these changes
Oct 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small suggestion, feel free to ignore if not apply.
In general it's a good job 👏
douglaslise
force-pushed
the
3ds-window-sizing
branch
2 times, most recently
from
October 11, 2022 18:38
5c57d4a
to
8b14cec
Compare
douglaslise
force-pushed
the
3ds-window-sizing
branch
3 times, most recently
from
October 12, 2022 14:27
8080eda
to
8f23ce8
Compare
douglaslise
force-pushed
the
3ds-window-sizing
branch
from
October 12, 2022 14:46
8f23ce8
to
a2fbd16
Compare
douglaslise
force-pushed
the
3ds-window-sizing
branch
from
October 12, 2022 21:47
a2fbd16
to
53c5b22
Compare
chrissrogers
approved these changes
Oct 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome PR!
ngleiser
approved these changes
Oct 17, 2022
recurly-integrations
pushed a commit
that referenced
this pull request
Nov 14, 2022
[Full Changelog](v4.22.4...v4.22.5) **Merged Pull Requests** - Update Minimum Apple Pay Version to v4 [#773](#773) ([cbarton](https://github.com/cbarton)) - Replace denodeify [#772](#772) ([wsethbrown](https://github.com/wsethbrown)) - Revert "Cartes Bancaires and Co-Branding support" [#760](#760) ([douglaslise](https://github.com/douglaslise)) - Adding challenge window size selections [#757](#757) ([tilley-kyle](https://github.com/tilley-kyle)) - Replace $ExpectError with @ts-expect-error [#755](#755) ([douglasmiller](https://github.com/douglasmiller)) - Cartes Bancaires and Co-Branding support [#752](#752) ([douglaslise](https://github.com/douglaslise)) ##### Minified MD5 Checksum ``` 3de0375127fbb06cdb55891b8325e01e ./build/recurly.min.js ``` ##### [SRI Hash](https://www.srihash.org/) ``` sFGpZNF9UIheArQaqfoCcsjtNLf3pkooBhDnH9a539HPZrLk78IdZ5T1i/HCRJdU ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are adding in the capability for a merchant to select what size they would like their instance of RJS to display the 3ds challenge iframe.
To test. Supply the
challengeWindowSize
field in the call to 3DS Risk. Your site should be set on sandbox and you can use a sandbox 3ds card to trigger a transaction.Example:
or