Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding challenge window size selections #757

Merged
merged 7 commits into from
Oct 17, 2022
Merged

Adding challenge window size selections #757

merged 7 commits into from
Oct 17, 2022

Conversation

tilley-kyle
Copy link
Contributor

@tilley-kyle tilley-kyle commented Oct 6, 2022

We are adding in the capability for a merchant to select what size they would like their instance of RJS to display the 3ds challenge iframe.

To test. Supply the challengeWindowSize field in the call to 3DS Risk. Your site should be set on sandbox and you can use a sandbox 3ds card to trigger a transaction.
Example:

risk.ThreeDSecure({
  actionTokenId: myActionTokenId,
  challengeWindowSize: risk.ThreeDSecure.CHALLENGE_WINDOW_SIZE_01_250_X_400,
});

or

risk.ThreeDSecure({
  actionTokenId: myActionTokenId,
  challengeWindowSize: '01',
});

@coveralls
Copy link

coveralls commented Oct 6, 2022

Coverage Status

Coverage increased (+0.04%) to 92.636% when pulling 53c5b22 on 3ds-window-sizing into e4233b4 on master.

douglaslise
douglaslise previously approved these changes Oct 7, 2022
Copy link
Contributor

@douglaslise douglaslise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small suggestion, feel free to ignore if not apply.
In general it's a good job 👏

lib/recurly/frame.js Outdated Show resolved Hide resolved
@douglaslise douglaslise force-pushed the 3ds-window-sizing branch 2 times, most recently from 5c57d4a to 8b14cec Compare October 11, 2022 18:38
Copy link
Member

@chrissrogers chrissrogers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome PR!

@ngleiser ngleiser merged commit 2626b26 into master Oct 17, 2022
@ngleiser ngleiser deleted the 3ds-window-sizing branch October 17, 2022 17:44
recurly-integrations pushed a commit that referenced this pull request Nov 14, 2022
[Full Changelog](v4.22.4...v4.22.5)

**Merged Pull Requests**

- Update Minimum Apple Pay Version to v4 [#773](#773) ([cbarton](https://github.com/cbarton))
- Replace denodeify [#772](#772) ([wsethbrown](https://github.com/wsethbrown))
- Revert "Cartes Bancaires and Co-Branding support" [#760](#760) ([douglaslise](https://github.com/douglaslise))
- Adding challenge window size selections [#757](#757) ([tilley-kyle](https://github.com/tilley-kyle))
- Replace $ExpectError with @ts-expect-error [#755](#755) ([douglasmiller](https://github.com/douglasmiller))
- Cartes Bancaires and Co-Branding support [#752](#752) ([douglaslise](https://github.com/douglaslise))

##### Minified MD5 Checksum
```
3de0375127fbb06cdb55891b8325e01e ./build/recurly.min.js
```
##### [SRI Hash](https://www.srihash.org/)
```
sFGpZNF9UIheArQaqfoCcsjtNLf3pkooBhDnH9a539HPZrLk78IdZ5T1i/HCRJdU
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants