Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes billing info prefill selectors. #98

Merged
merged 2 commits into from
Dec 2, 2013
Merged

Fixes billing info prefill selectors. #98

merged 2 commits into from
Dec 2, 2013

Conversation

lancekruegger
Copy link

This pull request fixes issue #78 and is based off of branch https://github.com/recurly/recurly-js/tree/fix-billing-prefill . User https://github.com/pyronicide had the initial idea but didn't actually fix the issue.

@aheckmann
Copy link

thanks! would you mind adding tests? if you're busy, i'll try to get something going in the next couple days.

@lancekruegger
Copy link
Author

Added tests. I noticed that the module for buildBillingInfoUpdateForm was calling the wrong function as well so I fixed that. Let me know if a refactor is required to match any conventions / style you guys may have.

aheckmann added a commit that referenced this pull request Dec 2, 2013
@aheckmann aheckmann merged commit 12ed988 into recurly:master Dec 2, 2013
@aheckmann
Copy link

LGTM. thanks!

@lancekruegger lancekruegger deleted the fix-billing-info-prefill branch December 2, 2013 22:59
@aheckmann
Copy link

Hi Lance. No we'll build it when we release the new version (soon).

On Tuesday, December 3, 2013, Lance Ruegger wrote:

@aheckmann https://github.com/aheckmann do contributors normally build
the final recurly.js and recurly.min.js files before submitting a PR?


Reply to this email directly or view it on GitHubhttps://github.com//pull/98#issuecomment-29731048
.

Aaron Heckmann
Tech Lead
aaron@recurly.com
https://github.com/aheckmann
https://twitter.com/aaronheckmann

@lancekruegger
Copy link
Author

Thanks! I had re-read the contributing file and noted that I was not supposed to.

@aheckmann
Copy link

2.2.9 has been released with your fix. thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants