Specify a base path when creating child process from ChildProcessFactory #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I found an issue when I launch my app from a launcher with ShadowCopy enabled. The ProcessStarter class in RedGate.AppHost.Server project use Assembly.GetExecutingAssembly().Location to get the base path for Client executables.
To resolve this "issue", I added a property to ProcessStarter and ChildProcessFactory, and I did two small changes to the ChildProcessFactory.Create function and the ChildProcessHandle.StartProcess function.
This is my first pull requests, and I would to pull only the commit 894310f. (I did other edits only to compile it and create a test Nuget package).
Thanks for the attention and for this project.
Best regards