Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the easier way how overwrite vars #57

Merged
merged 1 commit into from
May 20, 2019
Merged

Implement the easier way how overwrite vars #57

merged 1 commit into from
May 20, 2019

Conversation

petr-balogh
Copy link
Member

This patch implements the easier way how to overwrite the variables for
rendering the templates.

@petr-balogh
Implement the easier way how overwrite vars
915f61f 
This patch implements the easier way how to overwrite the variables for
rendering the templates.
@petr-balogh petr-balogh requested a review from a team as a code owner May 17, 2019 12:41
@petr-balogh
Copy link
Member Author

Should fixing those issues:

@petr-balogh petr-balogh self-assigned this May 17, 2019
@petr-balogh petr-balogh added bug Something isn't working documentation Documentation issue, improvement enhancement New feature or request labels May 17, 2019
clacroix12
clacroix12 approved these changes May 17, 2019
View reviewed changes
Copy link
Contributor

@clacroix12 clacroix12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

RazTamir
RazTamir approved these changes May 17, 2019
View reviewed changes
Copy link
Contributor

@RazTamir RazTamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@petr-balogh petr-balogh merged commit b0933ff into red-hat-storage:master May 20, 2019
This was referenced May 20, 2019
Closed
Closed
@mbukatov mbukatov mentioned this pull request May 20, 2019
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RazTamir RazTamir RazTamir approved these changes

@clacroix12 clacroix12 clacroix12 approved these changes

Assignees

@petr-balogh petr-balogh

Labels
bug Something isn't working documentation Documentation issue, improvement enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@petr-balogh @clacroix12 @RazTamir