-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update provider-api-server to be deployed in internal and provider mode #2718
Update provider-api-server to be deployed in internal and provider mode #2718
Conversation
Skipping CI for Draft Pull Request. |
@rewantsoni Please provide a proper PR title and description |
Can the provider handle requests for multiple storage clusters? Do we want to run only one ocs-provider-server deployment in case of the multiple storagecluster? If yes then we can have it as part of the ocs initialization otherwise it should be part of the storagecluster reconciliation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you pls add deprication warning in the storage cluster API in first commit?
Also pls separate the generated changes in the 3rd commit and rename the deployment to the ocs-server
.
Yes, the server should be able to handle multiple storage clusters, but the client will onboard to only the storageCluster in the same namespace as the provider-server
Yes, one provider-server for multiple storageClusters
I have added the deployment as a part of csv and secret, service as part of ocsinit |
1262792
to
e40e894
Compare
e40e894
to
6f674d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you pls resolve merge conflict
6f674d0
to
3df476d
Compare
/retest-required |
31745ee
to
a2d1009
Compare
a2d1009
to
c03d842
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
client-op needs an update after this gets merged, isn't it?
@leelavg I don't think we need any update in client o/p after merging this, let me know if I missed anything. |
c03d842
to
94b2cab
Compare
4c7435d
to
6b2be46
Compare
6b2be46
to
a74c39b
Compare
a74c39b
to
f9d9b4b
Compare
f9d9b4b
to
cb40c09
Compare
LGTM |
cb40c09
to
8eeab5a
Compare
rebased the PR |
@iamniting Can you please take a look as well? |
8eeab5a
to
c636ce3
Compare
The commit does the following: 1. Create service, deployment, onboarding job for both modes 2. Update the variable from watchnamespace to podnamespace 3. Remove hardcoded name for storagecluster 4. Move client configmap in storageclient Signed-off-by: Rewant Soni <resoni@redhat.com>
c636ce3
to
5d80d7d
Compare
Signed-off-by: Rewant Soni <resoni@redhat.com>
Signed-off-by: Rewant Soni <resoni@redhat.com>
moved unit-tests into a separate commit |
5d80d7d
to
c7cd50e
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: iamniting, rewantsoni The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/unhold |
225a479
into
red-hat-storage:main
Allow provider-server to be deployed in intenal and provider mode
Why?
This is a part of RDR for Provider Mode RHSTOR-4886.
With this epic, we are introducing rpc calls for odf to odf communication, the RPC's we have for this epic are limited to Onboarding a Storage Cluster on different Openshift clusters and Getting the Mirroring Info required for setting up RDR (refer #2671).
This can also be used to replace the mechanism we have in the internal mode for setting up Mirroring for blockpool using MCO's Agents.
Hence moving the ocs-provider-server deployment to be deployed in both modes to enable both client to provider communication and cross odf communication.
The PR does the following: