Feature/149 disable subscriptions #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lm-sec
approved these changes
Apr 4, 2024
There was a problem hiding this comment.
Great feature! I suggested a couple things for performance, since I have a PTSD from the months of February-March. Please consider before merging 🚀
Otherwise, in the list view, instead of a Disabled tag, what would you think of graying out the source icon (we have a RKS icon in gray) and updating the tooltip? It would be more subtle, idk if this is what we look for. ➡️ I realised that you added them for blocked assets as well. To stay coherent, I would not remove the tag.
Outstanding work! 💯
.../service/src/modules/database/subscriptions/cron-subscriptions/cron-subscriptions.service.ts
Show resolved
Hide resolved
packages/backend/jobs-manager/service/src/modules/database/subscriptions/subscriptions.dto.ts
Outdated
Show resolved
Hide resolved
packages/backend/jobs-manager/service/src/modules/database/subscriptions/subscriptions.dto.ts
Outdated
Show resolved
Hide resolved
packages/frontend/stalker-app/src/app/api/jobs/subscriptions/cron-subscriptions.service.ts
Show resolved
Hide resolved
.../service/src/modules/database/subscriptions/event-subscriptions/event-subscriptions.model.ts
Show resolved
Hide resolved
packages/backend/jobs-manager/service/src/modules/database/subscriptions/subscriptions.utils.ts
Show resolved
Hide resolved
packages/backend/jobs-manager/service/src/modules/findings/commands/findings-handler-base.ts
Show resolved
Hide resolved
packages/frontend/stalker-app/src/app/api/jobs/subscriptions/event-subscriptions.service.ts
Outdated
Show resolved
Hide resolved
.../frontend/stalker-app/src/app/modules/jobs/subscriptions/subscription-interaction.service.ts
Show resolved
Hide resolved
packages/frontend/stalker-app/src/app/modules/jobs/subscriptions/subscription-templates.ts
Outdated
Show resolved
Hide resolved
Feature/149 menus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows disabling subscriptions. By default, new subscriptions are disabled. This allows admins to save their progress without side-effects.
Other changes:
Disabling/enabling a subscription
Searching by disable/enabled
To-do (in a next PR)
Closes #149 .