Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RPM generation #40

Closed
wants to merge 4 commits into from
Closed

RPM generation #40

wants to merge 4 commits into from

Conversation

arodriguezdlc
Copy link
Contributor

No description provided.

@arodriguezdlc arodriguezdlc self-assigned this Jan 11, 2017
@arodriguezdlc
Copy link
Contributor Author

Please, first merge to master #38 pull request.

@arodriguezdlc arodriguezdlc mentioned this pull request Jan 11, 2017
Closed
@coveralls
Copy link

Coverage Status

Coverage remained the same at 57.891% when pulling ff1e58d on arodriguezdlc:feature/8619-rpm-packaging into cffaabd on redBorder:master.

@Bigomby Bigomby requested review from Bigomby and removed request for eugpermar February 15, 2017 13:06
@Bigomby Bigomby changed the base branch from master to develop February 15, 2017 13:10
Bigomby
Bigomby suggested changes Feb 15, 2017
View reviewed changes
Copy link
Contributor

@Bigomby Bigomby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make some tests for the RPM generation?

Bigomby
Bigomby reviewed Feb 15, 2017
View reviewed changes
Copy link
Contributor

@Bigomby Bigomby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its absolutely necessary for the f2k.service file to be on the root dir?

@Bigomby
Copy link
Contributor

Bigomby commented Feb 15, 2017

Sice #38 is merged you may want to update your pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bigomby Bigomby Bigomby requested changes

Assignees

@arodriguezdlc arodriguezdlc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arodriguezdlc @coveralls @Bigomby