Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make rbforwarder.Report an interface #20

Merged
merged 1 commit into from
Aug 4, 2016
Merged

Make rbforwarder.Report an interface #20

merged 1 commit into from
Aug 4, 2016

Conversation

Bigomby
Copy link
Contributor

@Bigomby Bigomby commented Aug 4, 2016 •
edited
Loading

Create a Reporter interface and add a methor Reports to the Messenger interface. This way allows component to use its own implementation of message and report.

  • Reports method for Messenger
  • Reporter interface

Closes #19

@Bigomby Bigomby self-assigned this Aug 4, 2016
@coveralls
Copy link

coveralls commented Aug 4, 2016 •
edited
Loading

Coverage Status

Coverage decreased (-2.4%) to 94.093% when pulling cbbb3ff on feature/reporter-interface into d86acde on develop.

@Bigomby Bigomby merged commit 30d3de1 into develop Aug 4, 2016
@Bigomby Bigomby deleted the feature/reporter-interface branch August 4, 2016 10:16
Bigomby added a commit that referenced this pull request Oct 3, 2016
@Bigomby
Merge pull request #20 from redBorder/feature/reporter-interface
70742e0 
Make rbforwarder.Report an interface
Bigomby added a commit that referenced this pull request Oct 18, 2016
@Bigomby
Merge pull request #20 from redBorder/feature/reporter-interface
a2d445c 
Make rbforwarder.Report an interface
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Bigomby Bigomby

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bigomby @coveralls