Patch cleanup #91
Merged
Patch cleanup #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
January 26, 2018 10:49
Issue remaining with meta queries and issue with HasOne property being fetched on patch
Newtonsoft considers Guid and String not equal even tho they stringify the same way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#64 No longer trying and failing to track all changes using Argo for a patch. Instead, compare the cached resource to the state of the passed in model. Trim any equivalent objects. Fixes a bug where changes to complex properties are not recognized. This trades off in-memory performance for over-the-wire performance for patches, since each property must be serialized for the compare. However, the sent patch is more concise (due to work-arounds for complex property updates needing to send massive patches). More work could be done to trim the patch further via JSON diff, but I didn't want to take on that work for this update.