Fix crashes during BLE and Wifi provisioning #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What made you wanna fix it? |
|
I ran into the same issue when provisioning my duo and had to resort to the serial terminal method which was a pain. After I looked at your comment I realized it was a simple fix so I went ahead and submitted it :) |
|
Wow, BLE provisioning has the same exact bug... can't believe this hasn't been fixed yet! I'll make another commit. |
Danappelxx
changed the title
yoiang
added a commit
to Adorkable-forkable/Duo
that referenced
this pull request
Sep 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @saamerm noted in #35 the iOS app crashes when unwrapping nil alert actions. I believe that this is due to allocating directly into a weak reference, leading to an initial reference count of zero and immediate deallocation. This PR addresses that.