Fix issue with task cancellation in Async(Throwing)?Stream initializers
#42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…zers Asynchrone's custom initializers for `AsyncStream` and `AsyncThrowingStream` were spawning a new task to wrap the async `build` block, but was not handling canceling that task whenthe `AsyncStream` was cancelled. This resulted in situations where cancellation was failing to propagate to the build block. The fix is to use the `continuation`s `onTermination` block to cancel the newly-spawned task.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asynchrone's custom initializers for
AsyncStreamandAsyncThrowingStreamspawn a new task to wrap the asyncbuildblock, but do not handling cancelling that task when theAsyncStreamis cancelled.This resulted in situations where cancellation was failing to propagate to the build block.
The fix is to use the
continuationsonTerminationblock to cancel the newly-spawned task.