switch to using scp for the copy dump file cmd #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is apparently faster than sftp but less feature-ful. We don't need a bunch of features for the copy so switch to get some extra speed in copying. This also switches off of using Dk's configured ssh args. This was a bug with the previous sftp implementation and is also an issue with this scp implementation. The ssh args and scp (or sftp) args aren't common so we can't blindly rely on them. Really the only "common" args are the `-o *` options. This switches to looking for optional args in a named param so that the scp args can be distinct from the ssh args.
|
@kellyredding - I'm good with this 💥 |
kellyredding
added a commit
that referenced
this pull request
Aug 17, 2016
* (hotfix) first pass README b5754c4 * add Script, Config, Db #1 * basic task mixin and internal task framework #2 * implement the Setup and Teardown tasks #3 * implement the Task mixin #5 * implement the Dump, CopyDump and Restore tasks #4 * (hotfix) switch much-plugin to a non-dev dependency ba53e13 * (hotfix) allow configuring multiple Script config blocks 4041d83 * auto-create a Task for each Script #6 * add a Script DSL method for setting the script's Task description #7 * initialize Scripts with the Task params #8 * (hotfix) properly create the nested Script Tasks 7b0279a * switch to using scp for the copy dump file cmd #9 * update the README to properly describe script task usage #10 * update to the latest assert/dk 6272839
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is apparently faster than sftp but less feature-ful. We
don't need a bunch of features for the copy so switch to get some
extra speed in copying.
This also switches off of using Dk's configured ssh args. This
was a bug with the previous sftp implementation and is also an
issue with this scp implementation. The ssh args and scp (or sftp)
args aren't common so we can't blindly rely on them. Really the
only "common" args are the
-o *options. This switches to lookingfor optional args in a named param so that the scp args can be
distinct from the ssh args.
@jcredding ready for review.