Runner Implementation #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The script now knows the command to copy the dump file from the source to the target. This involved commonizing some ssh related settings and adding in the cmd generation.
This adds a runner class that is responsible for running the script. Running involves running each phase (dump, copy, restore) and firing callbacks along the way. The runner also runs a setup and teardown that ensures the output dirs for both the source and target are available when needed and cleaned up when running is complete.
| @@ -49,6 +49,34 @@ MysqlFullRestore.new.run | |||
|
|
|||
| Dumpdb runs the dump commands using source settings and runs the restore commands using target settings. By default, Dumpdb assumes both the dump and restore commands are to be run on the local system. | |||
|
|
|||
| ### Runner Callbacks | |||
|
|
|||
| Dumpdb supports defining callbacks for your script. These get fired as the script is being run. To define a callback, just define a method named after the callback. | |||
There was a problem hiding this comment.
@kellyredding - "To define a callback, just define a method named after the callback." this is confusing to me, maybe "method named after the action" or something similar would be more clear?
There was a problem hiding this comment.
@kellyredding - oh your documentation explains the callbacks later, not so much an issue
There was a problem hiding this comment.
@jcredding - yeah, but you are right - that sentence is still confusing.
|
@kellyredding - Runner implementation looks good. 💰 The steps it takes to run a full dump and restore are clear. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the runner class that uses Scmd to run the script and call the callbacks. Pretty straightforward (I hope).