remove ns-options as a dependency #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kellyredding - Good stuff 💥 |
This is part of getting this gem working in modern ruby versions. We are moving away from using ns-options as a dependency b/c it has performance issues when accessing options and on top of that its API hasn't proven to be especially useful over a struct-like class. This removes the `:settings` options group. Since it was just handling option storage, I replaced it with a basic hash with the appropriate defaults set for each option value. I also brought in much-plugin since this is a mixin with an included hook.
kellyredding
force-pushed
the
kr-rm-ns-options
branch
from
26c40f1
to
43aa597
Compare
kellyredding
added a commit
that referenced
this pull request
Jun 14, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of getting this gem working in modern ruby versions.
We are moving away from using ns-options as a dependency b/c it
has performance issues when accessing options and on top of that
its API hasn't proven to be especially useful over a struct-like
class.
This removes the
:settingsoptions group. Since it was justhandling option storage, I replaced it with a basic hash with
the appropriate defaults set for each option value.
I also brought in much-plugin since this is a mixin with an
included hook.
@jcredding ready for review.