cleanups: reorg the output logic under a common module #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a cleanup effort in prep for removing ns-options. This centralizes all of the behavior under a common module in a single file. This also improves readability as you get to see all of the output logic side by side. It also shows how the outputs build on the base and all rely on ns-options (for now). In a future effort, I'll remove ns-options in prep for making this gem work in modern ruby versions.
|
@kellyredding - I'm cool with these organization changes 💥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cleanup effort in prep for removing ns-options. This
centralizes all of the behavior under a common module in a single
file. This also improves readability as you get to see all of
the output logic side by side. It also shows how the outputs
build on the base and all rely on ns-options (for now).
In a future effort, I'll remove ns-options in prep for making this
gem work in modern ruby versions.
@jcredding sorry for the massive red/green on the diff - its not very helpful in showing this is just some renames/reorgs. There are no behavior changes here. Are you cool with the new names/organization?