default template locals #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the source to optionally take default template locals. Locals are applied to an anonymous subclass of `Template` and this subclass is used to do all source renderings. The goal here is to apply a local that is used across all renders - one you don't have to remember to pass in and applies to both top level renders and partial renders. Specifically, this will be used by both the deas and sanford nm adapters to make their `logger` available in the templates.
|
@kellyredding - I follow, looks good 💥 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the source to optionally take default template locals.
Locals are applied to an anonymous subclass of
Templateand thissubclass is used to do all source renderings.
The goal here is to apply a local that is used across all renders -
one you don't have to remember to pass in and applies to both top
level renders and partial renders. Specifically, this will be used
by both the deas and sanford nm adapters to make their
loggeravailable in the templates.
@jcredding I realized the logger stuff I did in deas-nm previously won't fully work as the logger won't be available in partial calls. I had to go deeper and effect the template scope itself. Thus this feature. I'll go back and update deas-nm and sanford-nm to take advantage of this in coming PRs.