template cache #15
Merged
template cache #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -65,6 +65,24 @@ Output: | |||
|
|
|||
| ## Notes | |||
|
|
|||
| ### Cache Templates | |||
|
|
|||
| By default the source doesn't care template files. You can configure it to cache templates using the `:cache` option: | |||
There was a problem hiding this comment.
@kellyredding - "cache" instead of "care"
This adds logic to the source to enable template caching. This shows a modest improvement in the benchmarks relative to not caching. To accomplish this, I had to update the source api to take options rather than default locals directly. This also updates the the README to document the cache option as well as the default locals option.
kellyredding
force-pushed
the
kr-cache
branch
from
d77987b
to
3c0cc3c
Compare
|
@kellyredding - Looks good 💥 |
kellyredding
added a commit
that referenced
this pull request
Jan 19, 2015
* template cache #15 /cc @jcredding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds logic to the source to enable template caching. This
shows a modest improvement in the benchmarks relative to not caching.
To accomplish this, I had to update the source api to take options
rather than default locals directly. This also updates the the
README to document the cache option as well as the default locals
option.
@jcredding ready for review.