add render_content method to Nm::Context
#22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method is used to render raw template content strings and is composed by the `render` method that takes a template path. This keeps things DRY while adding a more flexible API. Specifically, this is needed to implement render Nm templates in Rails' template engine. I also added some equality methods to ease testing in the rails-nm gem that I'm working on.
kellyredding
added a commit
that referenced
this pull request
Jun 23, 2021
* 226911d - (hotfix) update to the latest much-style-guide * add render_content method to Nm::Context #22 * rework Nm::Template as Nm::TemplateBehaviors mixin #21 * prep for reworking template rendering to support e.g. Rails rendering #20 * 066ad42 - add Nm::Source `file_path!` method * 6965995 - rework Source to use keyword arguments; tweak argument handling * 2c05771 - remove `render` Template methods * update to our latest gem conventions #19 * 611e24e - configure t.rb and l.rb; lint the source * 40da810 - update to the latest Assert * 44bd8a3 - update to our latest gem conventions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method is used to render raw template content strings and is
composed by the
rendermethod that takes a template path. Thiskeeps things DRY while adding a more flexible API.
Specifically, this is needed to implement render Nm templates in
Rails' template engine.
I also added some equality methods to ease testing in the rails-nm
gem that I'm working on.