Use much-plugin for daemon, worker and handlers #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jcredding looks good man 👎 |
|
@jcredding I think we should use much plugin on the daemon too. |
jcredding
force-pushed
the
jcr-use-much-plugin
branch
2 times, most recently
from
c506934
to
1715574
Compare
jcredding
changed the title
This updates the daemon, worker and handler mixins to use much-plugin. This ensures the mixin logic is only included once and ensures the worker callbacks don't get added multiple times.
jcredding
force-pushed
the
jcr-use-much-plugin
branch
from
1715574
to
18c8c9d
Compare
jcredding
added a commit
that referenced
this pull request
Nov 24, 2015
Use much-plugin for daemon, worker and handlers
jcredding
added a commit
that referenced
this pull request
Nov 30, 2015
Use much-plugin for daemon, worker and handlers
jcredding
added a commit
that referenced
this pull request
Nov 30, 2015
* hotfix: cleanup block param name on applying worker procs (9s289ac) * Switch worker available from IO pipe to mutex/condition variable (#94) * Update to use the new scmd, setup for working with ruby 1.9+ (#95) * Hotfix: Expand exception factory method (eb1260b) * Move using the process label env var into the daemon data (#96) * move test helpers into the job/event handler source files (#97) * hotfix: runner cleanups (09fb09a) * message handler: make default `run!` method a no-op (#98) * message handler: make run callback method public; use in qs runner (#99) * cleanups: consistency with Deas/Sanford; namespace handler meths (#100) * hotfix - runner: build the handler last (8fd382b) * Hotfix: Update to latest ggem conventions (fcfda4b) * Update to use the new dat-worker-pool (#101) * Pass logger to dat-worker-pool when in debug mode (#102) * Use much-plugin for daemon, worker and handlers (#103) * Add worker test helpers (#104) * Rename `Signal` to `State`, use dat-worker-pool locked object (#105) * Feature: New dat-worker-pool (#106) /cc @kellyredding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the daemon, worker and handler mixins to use
much-plugin. This ensures the mixin logic is only included once and
ensures the worker callbacks don't get added multiple times.
@kellyredding - Ready for review.