Update to use the latest HellaRedis #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jcredding good stuff - love dat custom dat-worker-pool path! 👎 |
This updates HellaRedis and how it is used. The latest HellaRedis takes a hash directly so this allows removing the `RedisConnection`. This also changes the testing to use the `ConnectionSpy` provided by HellaRedis. This allows testing that the configuration was properly used when building a redis connection.
jcredding
force-pushed
the
jcr-new-hella-redis
branch
from
02175ac
to
30a8d78
Compare
jcredding
added a commit
that referenced
this pull request
Dec 30, 2014
Update to use the latest HellaRedis
jcredding
added a commit
that referenced
this pull request
Apr 24, 2015
* gem created with ggem (7b911ec) * setting up the gemspec (52da24d) * Add a `qs` bin and `CLI` class for it's logic (#4) * minor updates to the gem meta (#5) * Implement `Config` for evaluated config files (#6) * Add a `Process` class for managing Qs daemon processes (#7) * Make `Qs::Daemon` a mixin, not a class (#9) * Add daemon configuration, provides options and validation (#10) * Update daemon config and `Process` interaction (#11) * Update `Daemon` state and `Process` signal handling (#12) * Add `Daemon` work loop that uses `DatWorkerPool` (#13) * Add `Worker` class; parses job, finds handler and runs it (#14) * Add `ErrorHandler`, calls a list of procs when a job fails (#15) * Change `Daemon` state handling, rename to "signal" (#16) * Use dat-worker-pool's spy in the daemon tests (#17) * Simply CLI `Config` class (#18) * Use dependency-injection with `CLI` and ruby's `Kernel` (#19) * Update to latest gem conventions (#20) * Update `CLI`, add `ConfigFile` (#21) * Add `ProcessSignal` and `PIDFile` (#22) * Change `Daemon` module organization (5cbc537) * Remove `Config` tests (66c621c) * Add `Queue` and `Route` (#23) * Add `Logger` and `NullLogger` (#25) * Update and simplify `Process` (#24) * Add Redis configuration and connection (#27) * Add `DaemonData` (#26) * Add `JobHandler` mixin (#28) * Add runners for live and test environments (#29) * Add `Job`, handles converting to/from payloads (#30) * Update `ErrorHandler`, match Sanford error handler (#31) * Implement `Route#run` (#33) * Add `PayloadHandler`, processes a serialized payload (#32) * Add `Daemon::Configuration` (#34) * Add DSL methods for configuring a `Daemon` (#35) * Update `Daemon` with start, stop and halt (#36) * Update to use the latest HellaRedis (#39) * Add `enqueue` to `Qs` and `add` to `Queue` (#38) * Add redis connection and worker pool logic to `Daemon` (#37) * Remove `TmpDaemon`, use `Daemon` instead (#40) * Properly create/close IO pipes on start/shutdown (#41) * Add system tests for `Daemon` (#42) * Add benchmarking script (#43) * Add `TestHelpers` for mixin for building a runner/handler (#44) * Add `TestClient` and test mode, track enqueued jobs (#45) * Allow configuring a serializer/deserializer (#47) * Add job timeouts (#46) * Change restart cmd to check if `ENV['PWD']` is set (#49) * require daemon (ec77ffb) * Expand `ErrorHandler` to take more information (#50) * Add `push` and `prepend` to `Client` (#52) * Expand redis item to track the state of processing it (#51) * Update `Daemon` to build a client (#53) * Job's payload, convert name to a string (e1ada59) * Update to the latest `DatWorkerPool` (#54) * Add `Qs.push` for adding payloads to queues (#56) * Serialize when enqueuing and building test runner (#55) * Stop defaulting `@job_handler_ns` to `nil` in `Queue` (1e4df3e) /cc @kellyredding
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates HellaRedis and how it is used. The latest HellaRedis
takes a hash directly so this allows removing the
RedisConnection. This also changes the testing to use theConnectionSpyprovided by HellaRedis. This allows testing thatthe configuration was properly used when building a redis
connection.
@kellyredding - Ready for review. I'll rebase my other branches off of this so they can use it.